-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: get informant notification from country config #7627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
Zangetsu101
requested changes
Sep 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one small change request. Otherwise looks good. Only CHANGELOG entry required
packages/workflow/src/features/registration/sms-notification-utils.ts
Outdated
Show resolved
Hide resolved
Nil20
force-pushed
the
notification-record-endpoint
branch
from
September 18, 2024 11:45
d47d00b
to
c7b32b2
Compare
Zangetsu101
reviewed
Sep 18, 2024
Zangetsu101
changed the title
chore!: get informant notification from country config
chore: get informant notification from country config
Sep 18, 2024
Nil20
force-pushed
the
notification-record-endpoint
branch
from
September 18, 2024 12:20
7b6c54b
to
e0e088e
Compare
Nil20
force-pushed
the
notification-record-endpoint
branch
from
September 18, 2024 12:21
e0e088e
to
63b813c
Compare
Zangetsu101
approved these changes
Sep 18, 2024
Your environment is deployed to https://notification-record-endpoint.opencrvs.dev. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Country Config PR: opencrvs/opencrvs-countryconfig#274